Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use a local registry for remote scanning #7607

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

TestFanal_Library_DockerLessMode currently pulls images from GHCR, leading to flaky. We should use a local registry for this purpose. I plan to move all integration tests from fanal into trivy. This PR just moves TestFanal_Library_DockerLessMode to the trivy integration tests. I picked up only some of the images, as they are already well covered by other tests.

The new tests don't compare detected packages. I would like to add that in another PR.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Sep 27, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 marked this pull request as ready for review September 27, 2024 10:16
@knqyf263 knqyf263 added this pull request to the merge queue Sep 27, 2024
Merged via the queue into aquasecurity:main with commit 9baf658 Sep 27, 2024
12 checks passed
@knqyf263 knqyf263 deleted the test/local_registry branch September 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants